Updates resource visibility when handling PATCH api to update sharing record#5654
Merged
cwperks merged 2 commits intoopensearch-project:mainfrom Sep 25, 2025
Merged
Conversation
… record Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
requested review from
RyanL1997,
cwperks,
derek-ho,
nibix,
peternied,
reta,
shikharj05 and
willyborankin
as code owners
cwperks
reviewed
Sep 25, 2025
...ugin/src/integrationTest/java/org/opensearch/sample/resource/securityapis/ShareApiTests.java
Show resolved
Hide resolved
cwperks
previously approved these changes
Sep 25, 2025
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
cwperks
approved these changes
Sep 25, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5654 +/- ##
=======================================
Coverage 72.89% 72.90%
=======================================
Files 413 413
Lines 25750 25758 +8
Branches 3917 3917
=======================================
+ Hits 18771 18778 +7
- Misses 5064 5065 +1
Partials 1915 1915
🚀 New features to boost your workflow:
|
RyanL1997
approved these changes
Sep 25, 2025
RyanL1997
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the resource visibility update call that was somehow missed in this PR: #5596
After patching a resource sharing record, searching will not work for the updated entities as expected as
all_shared_principalsin the resource document will not be updated without this change.Testing
Manual + Automated testing
Check List
- [ ] New functionality has been documented- [ ] New Roles/Permissions have a corresponding security dashboards plugin PR- [ ] API changes companion pull request createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.